fix(sync/l2): retry fetching signature until we succeed#3023
Merged
Conversation
vbar
approved these changes
Sep 24, 2025
CHr15F0x
approved these changes
Sep 24, 2025
t00ts
reviewed
Sep 24, 2025
kkovaacs
force-pushed
the
krisztian/retry-fetching-signature-until-success
branch
from
e7f86a5 to
ec06039
Compare
There is a race condition with the current setup of Starknet feeder gateway: we've observed that fetching the signature sometimes fails even after fetching the block itself succeeds. We currently fail on such errors and exit the L2 sync task, which is not ideal. This change modifies the logic to retry fetching the signature until it succeeds.
kkovaacs
force-pushed
the
krisztian/retry-fetching-signature-until-success
branch
from
ec06039 to
fa99523
Compare
kkovaacs
deleted the
krisztian/retry-fetching-signature-until-success
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a race condition with the current setup of Starknet feeder gateway: we've observed that fetching the signature sometimes fails even after fetching the block itself succeeds. We currently fail on such errors and exit the L2 sync task, which is not ideal.
This change modifies the logic to retry fetching the signature until it succeeds.